chore: cleanup frontend dependencies, remove storybook #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
force-pushed
the
chore/cleanup-js-dependencies
branch
from
b0ceaeb to
f3d82aa
Compare
aleks-p
force-pushed
the
chore/cleanup-js-dependencies
branch
from
eae793d to
e10ff9e
Compare
|
@Rperry2174 any thoughts on removing storybook from the frontend project here? As I wrote above it seems to be broken atm and it causes a security alert that can't be easily addressed. |
grafakus
reviewed
Oct 3, 2024
| @@ -75,7 +66,6 @@ | |||
| "conventional-changelog-cli": "^2.1.1", | |||
| "copy-webpack-plugin": "^11.0.0", | |||
| "cypress": "^12.11.0", | |||
| "cypress-image-snapshot": "^4.0.1", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
That is in the og folder which in my understanding is mostly there for reference but it is unused and has its own package.json.
grafakus
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Removing code always looks good to me! 🥳
I'm just wondering if @Rperry2174 has some opinion on removing StoryBook.
korniltsev
pushed a commit
that referenced
this pull request
Oct 28, 2024
* chore: cleanup frontend dependencies, remove storybook * Run prettier * Remove explicit @mui/types dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few cleanup changes for the frontend:
Tested with:
cc @grafakus