Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the link to data source plugin #3611

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ifrost
Copy link
Contributor

@ifrost ifrost commented Oct 7, 2024

Adding missing "/" in https://grafana.com/docs/pyroscope/latest/introduction/pyroscope-in-grafana/:

You can use Pyroscope within Grafana by using the Pyroscope data source plugin. This plugin lets you query Pyroscope data from within Grafana and visualize it alongside your other Grafana data.

@ifrost ifrost requested review from a team as code owners October 7, 2024 12:25
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the link! Please sign the CLA and we'll get this merged.

@knylander-grafana knylander-grafana added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.9 labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR must be merged before a backport PR will be created.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR must be merged before a backport PR will be created.

@knylander-grafana knylander-grafana merged commit 9202a1f into grafana:main Oct 10, 2024
18 checks passed
Copy link
Contributor

The backport to release/v1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3611-to-release/v1.8 origin/release/v1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 9202a1f9906070f94568e579bdf719b1af00729a

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3611-to-release/v1.8
# Create the PR body template
PR_BODY=$(gh pr view 3611 --json body --template 'Backport 9202a1f9906070f94568e579bdf719b1af00729a from #3611{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.8] docs: Fix the link to data source plugin' --body-file - --label 'type/docs' --label 'backport' --base release/v1.8 --milestone release/v1.8 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3611-to-release/v1.8

# Create a pull request where the `base` branch is `release/v1.8` and the `compare`/`head` branch is `backport-3611-to-release/v1.8`.

# Remove the local backport branch
git switch main
git branch -D backport-3611-to-release/v1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants