refactor: move query-blocks to admin blocks query #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoba13
force-pushed
the
alsoba13/cli-refactor-admin-block
branch
2 times, most recently
from
48f590d to
c794fba
Compare
alsoba13
force-pushed
the
alsoba13/cli-refactor-admin-block
branch
from
c794fba to
27533b4
Compare
kolesnikovae
approved these changes
Oct 15, 2024
| blocksQueryCmd := blocksCmd.Command("query", "Query on local/remote blocks.") | ||
| blocksQuerySeriesCmd := blocksQueryCmd.Command("series", "Request series labels on local/remote blocks.") | ||
| blocksQuerySeriesParams := addBlocksQuerySeriesParams(blocksQuerySeriesCmd) | ||
| blocksQueryMergeCmd := blocksQueryCmd.Command("merge", "Request merged profile on local/remote block.") |
There was a problem hiding this comment.
Should we call id "profile" and create an alias?
marcsanmi
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
query-blockstoadmin blocks query.