Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update helm release workflow with github app secrets #3631

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: update helm release workflow with github app secrets #3631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/helm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ on:
- main
- "release-[0-9]+.[0-9]+"

# NOTE: We need to store GH_RELEASES_APP_ID and GH_RELEASES_APP_PRIVATE_KEY as repository secrets
# (even though we already store them in Vault) due to limitations in how secrets can be
# accessed and passed between different parts of a GitHub Actions workflow.
#
# The grafana/helm-charts/.github/workflows/update-helm-repo.yaml is a reusable workflow,
# not a composite action. This means we can't run steps to retrieve secrets from Vault
# before calling this workflow within the same job.
#
# While we have access to the grafana/shared-workflows/actions/get-vault-secrets@main action,
# environment variables set by this action in one job are not accessible in other jobs or
# in reusable workflows called from this workflow.

jobs:
call-update-helm-repo:
uses: grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main
Expand All @@ -14,4 +26,5 @@ jobs:
cr_configfile: operations/pyroscope/helm/cr.yaml
ct_configfile: operations/pyroscope/helm/ct.yaml
secrets:
helm_repo_token: ${{ secrets.GH_BOT_ACCESS_TOKEN }}
github_app_id: ${{ secrets.GH_RELEASES_APP_ID }}
github_app_private_key: ${{ secrets.GH_RELEASES_APP_PRIVATE_KEY }}
Loading