Add rideshare example for integrating with k6 #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanhuhta
commented
Oct 28, 2024
Comment on lines
+84
to
+100
| for i := 0; i < vus; i++ { | ||
| doneChs[i] = make(chan struct{}) | ||
|
|
||
| go func(done <-chan struct{}) { | ||
| for { | ||
| select { | ||
| case <-done: | ||
| return | ||
| default: | ||
| err := sendThrottledRequest(context.Background(), url, sleep, jitter) | ||
| if err != nil { | ||
| log.Printf("failed to send request to %s: %v", url, err) | ||
| } | ||
| } | ||
| } | ||
| }(doneChs[i]) | ||
| } |
There was a problem hiding this comment.
This is the main continuous load test loop (different from a k6 load test). This is slightly altered from the original rideshare example. The original was aware of each replica and would try evenly distribute requests across all of them.
Since we now put all the replicas behind a nginx proxy, the load test program does not need to try evenly balance load across all of them. Now we spin up the defined number of VUs and have the make random endpoint requests to the proxy itself.
bryanhuhta
commented
Oct 28, 2024
examples/language-sdk-instrumentation/golang-push/rideshare-k6/main.go
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare-k6/README.md
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare-k6/README.md
Outdated
Show resolved
Hide resolved
marcsanmi
approved these changes
Oct 28, 2024
examples/language-sdk-instrumentation/golang-push/rideshare-k6/main.go
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare-k6/README.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a copy of the existing Go Rideshare example, but now with k6 middleware added to the handlers.
To make the load test script easier to understand, I opted to add an nginx proxy in front of the ride share services. This means the k6 load test script can make requests to a single endpoint instead of having to add extra logic to evenly distribute load across all the services.
cc @Rperry2174