-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation for Pyroscope SDK profiles through Alloy #3658
Conversation
|
||
This document explains these two techniques and guide you when to choose each one. | ||
This document explains these techniques and guide you when to choose each one. | ||
|
||
![Pyroscope agent server diagram](https://grafana.com/media/docs/pyroscope/pyroscope_client_server_diagram_09_18_2024.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated with the new image @Rperry2174
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just put in a request with design team sorry for delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent doc updates! Thank you for the additions! I don't think there will be many conflicts with. my other PR.
docs/sources/configure-client/grafana-alloy/receive_profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/grafana-alloy/receive_profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/grafana-alloy/receive_profiles.md
Outdated
Show resolved
Hide resolved
a11899b
to
f605bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent addition. I have some small changes, mostly very minor wording and formatting. Thank you for updating the content!
When this is merged, do you want the content to be visible in the currently published Grafana docs for 11.3? If so, we'll need to add a backport label for 11.3 to the PR. |
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
5468a60
to
6e37b31
Compare
* docs: add documentation for Pyroscope SDK profiles through Alloy Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 44b9335)
* docs: add documentation for Pyroscope SDK profiles through Alloy Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 44b9335)
DO NOT MERGE until next Alloy release happens.As of now, latest is https://github.com/grafana/alloy/releases/tag/v1.4.3
This PR adds documentation for the new feature that allows sending profiles from Pyroscope SDKs through Alloy.