Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add home link and sources in Helm chart #3678

Merged
merged 1 commit into from
Nov 14, 2024
Merged

docs: add home link and sources in Helm chart #3678

merged 1 commit into from
Nov 14, 2024

Conversation

froblesmartin
Copy link
Contributor

This is useful to display some links on the artifacthub page: https://artifacthub.io/packages/helm/grafana/pyroscope

For example, you can check the cert-manager one: https://artifacthub.io/packages/helm/cert-manager/cert-manager

image

@froblesmartin froblesmartin requested a review from a team as a code owner November 13, 2024 06:29
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

marcsanmi
marcsanmi reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @froblesmartin, thanks for the contribution!
Could you run make helm/docs to update the documentation?

@froblesmartin
Copy link
Contributor Author

Hi @froblesmartin, thanks for the contribution! Could you run make helm/docs to update the documentation?

Done! Thanks for checking! :)

@marcsanmi
Copy link
Contributor

I missed that you're using the old home page https://pyroscope.io/ instead of the new one https://grafana.com/oss/pyroscope/. Could you update it please?

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Nov 13, 2024
@froblesmartin
docs: add home link and sources in Helm chart
c7d1ffa 
This is useful to display some links on the artifacthub page: https://artifacthub.io/packages/helm/grafana/pyroscope

For example, you can check the cert-manager one: https://artifacthub.io/packages/helm/cert-manager/cert-manager

Signed-off-by: Francisco Robles Martín <f.robles.martin@pm.me>
@froblesmartin
Copy link
Contributor Author

I missed that you're using the old home page https://pyroscope.io/ instead of the new one https://grafana.com/oss/pyroscope/. Could you update it please?

Done 👌

marcsanmi
marcsanmi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcsanmi marcsanmi merged commit d320fcd into grafana:main Nov 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcsanmi marcsanmi marcsanmi approved these changes

Assignees
No one assigned
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@froblesmartin @CLAassistant @marcsanmi @knylander-grafana