Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(docs.sources.configureServer.aboutServerAPI): fix typo #3686

Merged
merged 1 commit into from
Nov 18, 2024
Merged

doc(docs.sources.configureServer.aboutServerAPI): fix typo #3686

merged 1 commit into from
Nov 18, 2024

Conversation

dancer1325
Copy link
Contributor

Description

  • Fix typo

Context

  • About JFR format, and describing the supported profile types

How to review?

  • Check that
    • the description referes to the outside of tlab
    • the referered to the tlab was defined previosly

@dancer1325 dancer1325 requested review from a team as code owners November 14, 2024 17:45
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

alfredo-toledano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Nov 14, 2024
knylander-grafana
knylander-grafana approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs. please sign the CLA and we can merge your update.

@knylander-grafana knylander-grafana added the backport release/v1.10 This label will backport a merged PR to the release/v1.10 branch label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@dancer1325 dancer1325 force-pushed the doc/fix_serverapi_typo branch from 91e85c4 to f6fd662 Compare November 14, 2024 17:55
@dancer1325
Copy link
Contributor Author

Thank you for updating the docs. please sign the CLA and we can merge your update.

you are welcome 🎩

sign it

@aleks-p aleks-p merged commit a569ae1 into grafana:main Nov 18, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
@dancer1325 @grafana-delivery-bot
doc(docs.sources.configureServer.aboutServerAPI): fix typo (#3686)
2f052aa 
(cherry picked from commit a569ae1)
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
aleks-p pushed a commit that referenced this pull request Nov 18, 2024
@github-actions @dancer1325
doc(docs.sources.configureServer.aboutServerAPI): fix typo (#3686) (#…
4aa149c 
…3700)

(cherry picked from commit a569ae1)

Co-authored-by: dancer13 <alfredotic0809@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana approved these changes

Assignees
No one assigned
Labels
backport release/v1.10 This label will backport a merged PR to the release/v1.10 branch type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dancer1325 @CLAassistant @knylander-grafana @aleks-p