Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): raft module refactoring #3699

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Nov 17, 2024

The change moves raft component to a separate package metastore/raftnode, RaftNodeService is refactored as well. In addition, the state reader abstraction should prevent any confusion mentioned in #3502.

The change also fixes the way FSM is initialized: now that we explicitly separate read-only and write transaction, the state should be initialized explicitly as well.

@kolesnikovae kolesnikovae marked this pull request as ready for review November 18, 2024 08:25
@kolesnikovae kolesnikovae requested a review from a team as a code owner November 18, 2024 08:25
@kolesnikovae kolesnikovae requested a review from aleks-p November 18, 2024 12:24
Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

pkg/experiment/metastore/fsm/boltdb.go Outdated Show resolved Hide resolved
@kolesnikovae kolesnikovae merged commit 4496fe2 into main Nov 19, 2024
18 checks passed
@kolesnikovae kolesnikovae deleted the chore/raft-module-refactoring branch November 19, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants