fix: enable-ipv6 option is ignored
#3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
fix/ipv6-support
branch
from
6238946 to
cc73683
Compare
kolesnikovae
commented
Nov 30, 2024
Comment on lines
+547
to
+553
| ring: | ||
| # The key-value store used to share the hash ring across multiple instances. | ||
| kvstore: | ||
| # Backend storage to use for the ring. Supported values are: consul, etcd, | ||
| # inmemory, memberlist, multi. | ||
| # CLI flag: -distributor.ring.store | ||
| [store: <string> | default = "memberlist"] |
There was a problem hiding this comment.
For some reason, the distributor's ring configuration was omitted from the documentation, even though it is still available in the CLI help message. I've added it to the config spec doc.
kolesnikovae
commented
Nov 30, 2024
Comment on lines
-849
to
+1026
| [address: <string> | default = ""] | ||
| [instance_addr: <string> | default = ""] |
There was a problem hiding this comment.
I bet many people have been caught by this unfortunate inconsistency: we use instance_addr everywhere else. In the CLI, it's actually instance-addr, what makes things even more confusing.
To prevent any future confusion, I'm changing address to instance_addr while maintaining backward compatibility with the previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our configuration includes an option to enable IPv6 interface discovery when a component's advertised address is not explicitly defined. However, for unknown reasons, this option is not currently utilized, which can be quite confusing.
This PR addresses the issue by ensuring the relevant configuration parameters are properly applied. It is a no-op in most cases but may impact deployments intended to use IPv6.