fix: otlp pprof fixes #3741
fix: otlp pprof fixes #3741
Conversation
| dst.Location = []*googleProfile.Location{} | ||
| locationMappingIndexAddressMap := make(map[uint64]uint64) | ||
| // Convert locations and mappings | ||
| for i, loc := range src.Location { | ||
| gl := convertLocationBack(loc) | ||
| gl.Id = uint64(i + 1) | ||
| if len(gl.Line) == 0 { |
There was a problem hiding this comment.
So my understanding is that we only create those "placeholder" functions currently, as our query path relies on them to deduplicate.
I think a comment would be nice explaining that.
Maybe something worth considering doing later in the write path. Because if I sent currently Google pprofs without symbols I have the exact same problem. Or am I missing something 😂
There was a problem hiding this comment.
Hmm... I didn't test it, but it should be the same if we happen to receive pprof without symbols (lines) 😅
There was a problem hiding this comment.
I think frontend or read path just skips these locations.
vs
I think it is mostly needed to show the correct shape of the flamegraph - display that there were some frames we just could not name them
| } | ||
| return int64(stringmap[s]) | ||
| } | ||
| addstr("") |
There was a problem hiding this comment.
I think it is better to do it explicitly for https://github.com/google/pprof/blob/1e3fdc7de4679692c8c3bafdb87274f45090c73a/proto/profile.proto#L66
| dst.Location = []*googleProfile.Location{} | ||
| locationMappingIndexAddressMap := make(map[uint64]uint64) | ||
| // Convert locations and mappings | ||
| for i, loc := range src.Location { | ||
| gl := convertLocationBack(loc) | ||
| gl.Id = uint64(i + 1) | ||
| if len(gl.Line) == 0 { |
There was a problem hiding this comment.
Hmm... I didn't test it, but it should be the same if we happen to receive pprof without symbols (lines) 😅
libfoo.so 0x...