examples: add python span profiling #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
force-pushed
the
marcsanmi/examples-python-tracing
branch
from
2e394a3 to
d1033c0
Compare
Maybe I remembered it wrong, but in one of the team meetings I think we spoke about loadgen go vs. python and that we should use the go one everywhere, but I might be misremembering that. I personally think it is ok to reduce it to go. The python example is mainly the rideshare. |
simonswine
reviewed
Dec 11, 2024
simonswine
reviewed
Dec 11, 2024
marcsanmi
force-pushed
the
marcsanmi/examples-python-tracing
branch
from
6b80f3d to
e9cc8e8
Compare
marcsanmi
force-pushed
the
marcsanmi/examples-python-tracing
branch
from
e9cc8e8 to
c368dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers
I'm currently reusing the Golang load generator since it's already instrumented with OpenTelemetry for tracing and profiling.
Should we copy the load generator code into this example instead of referencing it? (I could have done the same with the Flask code, but I'd prefer the example to be self-contained...). That's why I'm leaning towards adding the load generator in this example as well.
Note that
span_nameis only available for the load generator sinceotel-profiling-pythondoesn't add it as label unlikeotel-profiling-go.