docs: update rust example and readme #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
korniltsev
commented
Dec 13, 2024
korniltsev
commented
- Add rust rideshare readme with screenshots from explore-profiles
- Update update_examples.go to update rust examples
- Update rideshare example to fix bugs with mutex_lock
- Update loadgen to use more threads for smoother metric
korniltsev
force-pushed
the
docs/rust
branch
from
899f9ad to
49ab6b6
Compare
|
Ah, I need to update screenshots too |
kolesnikovae
approved these changes
Dec 13, 2024
|
One minor note: please consider using Labels instead of Tags UPD: Please ignore this – we can revisit it later at some point |
| profiling has become an increasingly popular tool for the monitoring and debugging of performance issues (arguably the | ||
| fourth pillar of observability). | ||
|
|
||
| We'd love to continue to improve our Rust integrations, and so we would love to hear what features _you would like to |
There was a problem hiding this comment.
Should we include a suggested method for contacting us?
There was a problem hiding this comment.
idk, This was copypasted from somewhere else. There used to be a twitter handle on one of screenshots. If we need to suggest a method, it should be done everywhere
knylander-grafana
added
the
type/docs
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
|
@knylander-grafana Thank you a lot for the feedback! The readme was mostly copypopasted from ruby or golang example. I suggest we should update the wording there in a similar way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.