-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): rename flask-ride-sharing-app in tutorial #3778
Conversation
… from the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Was not really aware of killercoda.com. I imagine we need to backport those PRs, in order to update the "latest" version of the docs.
Hello @simonswine!
Please, if the current pull request addresses a bug fix, label it with the |
1 similar comment
Hello @simonswine!
Please, if the current pull request addresses a bug fix, label it with the |
This PR must be merged before a backport PR will be created. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3778-to-release/v1.9 origin/release/v1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7ec96ae36b26e9cc404881c62986128557be71d6 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3778-to-release/v1.9
# Create the PR body template
PR_BODY=$(gh pr view 3778 --json body --template 'Backport 7ec96ae36b26e9cc404881c62986128557be71d6 from #3778{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.9] chore(examples): rename flask-ride-sharing-app in tutorial' --body-file - --label 'type/docs' --label 'backport' --base release/v1.9 --milestone release/v1.9 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3778-to-release/v1.9
# Create a pull request where the `base` branch is `release/v1.9` and the `compare`/`head` branch is `backport-3778-to-release/v1.9`.
# Remove the local backport branch
git switch main
git branch -D backport-3778-to-release/v1.9 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3778-to-release/v1.10 origin/release/v1.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7ec96ae36b26e9cc404881c62986128557be71d6 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3778-to-release/v1.10
# Create the PR body template
PR_BODY=$(gh pr view 3778 --json body --template 'Backport 7ec96ae36b26e9cc404881c62986128557be71d6 from #3778{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.10] chore(examples): rename flask-ride-sharing-app in tutorial' --body-file - --label 'type/docs' --label 'backport' --base release/v1.10 --milestone release/v1.10 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3778-to-release/v1.10
# Create a pull request where the `base` branch is `release/v1.10` and the `compare`/`head` branch is `backport-3778-to-release/v1.10`.
# Remove the local backport branch
git switch main
git branch -D backport-3778-to-release/v1.10 |
In #3769 I renamed the
flask-ride-sharing-app
toride-sharing-app
to align with the shared README, where it is referred to in this way. However, in the KillerCoda tutorial, we're still usingflask-ride-sharing-app
. I'm updating the tutorial to reflect the new name and add a link to README.