fix(otel): split otel profile to multiple pprof profile if samples have service.name attribute #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
approved these changes
Dec 19, 2024
| MemoryLimit: om.MemoryLimit, | ||
| FileOffset: om.FileOffset, | ||
| Filename: p.addstr(p.src.StringTable[om.Filename]), | ||
| BuildId: p.addstr(p.src.StringTable[om.BuildId]), |
There was a problem hiding this comment.
This isn't going to work with the new spec.
However, not related to this PR since we're relying on om.BuildId before. I created an issue last week https://github.com/grafana/pyroscope-squad/issues/295
| otlpb.profile.LocationIndices = []int64{0, 1, 2, 3} | ||
|
|
||
| // Create two samples with different service.name attributes and different stacktraces | ||
| otlpb.profile.Sample = []*v1experimental.Sample{{ |
There was a problem hiding this comment.
Could we add a third sample without service name? We should expect a separate profile with service_name=unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.