cypress: cleanup nasty waitInDevMode #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborted requests when component is unmounting which usually happens in cypress tests since we click around faster than the server responds
eh-am
force-pushed
the
abort-request-when-changing-page
branch
from
43a1027 to
c90fe06
Compare
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 51.06% 51.02% -0.03%
==========================================
Files 117 117
Lines 5251 5251
==========================================
- Hits 2681 2679 -2
- Misses 2311 2313 +2
Partials 259 259
Continue to review full report at Codecov.
|
petethepig
approved these changes
Sep 6, 2021
korniltsev
pushed a commit
that referenced
this pull request
Jul 18, 2023
Update issue templates to include a bug template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the cypress tests where flaky, as they were failing due the
.thencallbacks offetchtrying to access an unmounted component (thinksetState).I added a nasty
waitInDevModeto avoid that.This PR cleans it up.
Since I was at it (ie. these weren't necessarily affecting the tests), I decided to add code to abort other requests too.