Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimizations 2 #391

Closed
wants to merge 6 commits into from
Closed

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 14, 2021

this is the same as #385, just to test server benchmark reports

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #391 (40f9327) into main (0403cee) will decrease coverage by 0.02%.
The diff coverage is 70.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   49.52%   49.51%   -0.01%     
==========================================
  Files         121      124       +3     
  Lines        5499     5608     +109     
==========================================
+ Hits         2723     2776      +53     
- Misses       2508     2568      +60     
+ Partials      268      264       -4     
Impacted Files Coverage Δ
pkg/storage/periodic.go 56.00% <ø> (-19.47%) ⬇️
pkg/storage/tree/serialize.go 56.38% <16.67%> (-13.70%) ⬇️
pkg/storage/dict/dict.go 75.76% <60.00%> (-9.42%) ⬇️
pkg/storage/cache/lfu/lfu.go 60.40% <60.40%> (ø)
pkg/storage/cache/cache.go 67.61% <64.87%> (+10.75%) ⬆️
pkg/storage/codec.go 75.00% <75.00%> (ø)
pkg/storage/dict/trie.go 75.44% <81.82%> (+0.44%) ⬆️
pkg/storage/storage.go 57.68% <85.72%> (-5.90%) ⬇️
pkg/storage/metrics.go 100.00% <100.00%> (ø)
pkg/storage/tree/tree.go 83.34% <100.00%> (+0.36%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0403cee...40f9327. Read the comment docs.

@eh-am
Copy link
Collaborator Author

eh-am commented Sep 14, 2021

retest this please

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Sep 14, 2021

Benchmark Result

main pr diff threshold
throughput 171.37 171.31 -0.06 (-0.03%) 5%
total items processed 338251.00 337757.00 -494.00 (-0.15%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Benchmark Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 0e9d922

@eh-am
Copy link
Collaborator Author

eh-am commented Sep 14, 2021

retest this please

@eh-am eh-am force-pushed the performance-optimizations-2 branch from 30ee984 to 40f9327 Compare September 14, 2021 17:31
@eh-am eh-am marked this pull request as draft September 14, 2021 21:01
@eh-am eh-am closed this Sep 22, 2021
@Rperry2174 Rperry2174 deleted the performance-optimizations-2 branch February 16, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants