chore: add GCS HTTP config #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
chore/gcs-http-config
branch
2 times, most recently
from
cb0d7f4 to
3d0ae4e
Compare
kolesnikovae
force-pushed
the
chore/gcs-http-config
branch
from
3d0ae4e to
b007f51
Compare
# Conflicts: # pkg/phlare/phlare.go
simonswine
approved these changes
Mar 14, 2025
Comment on lines
+34
to
+43
| type HTTPConfig struct { | ||
| IdleConnTimeout time.Duration `yaml:"idle_conn_timeout"` | ||
| ResponseHeaderTimeout time.Duration `yaml:"response_header_timeout"` | ||
| InsecureSkipVerify bool `yaml:"insecure_skip_verify"` | ||
| TLSHandshakeTimeout time.Duration `yaml:"tls_handshake_timeout"` | ||
| ExpectContinueTimeout time.Duration `yaml:"expect_continue_timeout"` | ||
| MaxIdleConns int `yaml:"max_idle_conns"` | ||
| MaxIdleConnsPerHost int `yaml:"max_idle_conns_per_host"` | ||
| MaxConnsPerHost int `yaml:"max_conns_per_host"` | ||
| } |
There was a problem hiding this comment.
Probably better to mark them all as advanced:
Suggested change
| type HTTPConfig struct { | |
| IdleConnTimeout time.Duration `yaml:"idle_conn_timeout"` | |
| ResponseHeaderTimeout time.Duration `yaml:"response_header_timeout"` | |
| InsecureSkipVerify bool `yaml:"insecure_skip_verify"` | |
| TLSHandshakeTimeout time.Duration `yaml:"tls_handshake_timeout"` | |
| ExpectContinueTimeout time.Duration `yaml:"expect_continue_timeout"` | |
| MaxIdleConns int `yaml:"max_idle_conns"` | |
| MaxIdleConnsPerHost int `yaml:"max_idle_conns_per_host"` | |
| MaxConnsPerHost int `yaml:"max_conns_per_host"` | |
| } | |
| type HTTPConfig struct { | |
| IdleConnTimeout time.Duration `yaml:"idle_conn_timeout"` `category:"advanced"` | |
| ResponseHeaderTimeout time.Duration `yaml:"response_header_timeout"` `category:"advanced"` | |
| InsecureSkipVerify bool `yaml:"insecure_skip_verify"` `category:"advanced"` | |
| TLSHandshakeTimeout time.Duration `yaml:"tls_handshake_timeout"` `category:"advanced"` | |
| ExpectContinueTimeout time.Duration `yaml:"expect_continue_timeout"` `category:"advanced"` | |
| MaxIdleConns int `yaml:"max_idle_conns"` `category:"advanced"` | |
| MaxIdleConnsPerHost int `yaml:"max_idle_conns_per_host"` `category:"advanced"` | |
| MaxConnsPerHost int `yaml:"max_conns_per_host"` `category:"advanced"` | |
| } |
There was a problem hiding this comment.
I've been thinking about it and decided to make it symmetric with the S3 config.
Actually, now that I look at it, it should be advanced – I'll add it in the follow up PR
There was a problem hiding this comment.
Adding it in #4007
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
* chore: add GCS HTTP config * chore: update help message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change will allow tuning the HTTP conn pool: the default parameters may cause excessive TLS handshakes:
Defaults:
1K idle connections, 10m idle timeout:
N.B.: it's worth exploring the GCS gRPC interface as well.