feat(v2): raft wait-committed #4072
Open
+72
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
feat/raft-commit-only
branch
2 times, most recently
from
3b12942 to
43d8bfb
Compare
kolesnikovae
force-pushed
the
feat/raft-commit-only
branch
from
f59273f to
7a5921c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to decouple the metadata read and write paths, ensuring that adding metadata entries does not have to wait for FSM application. This is particularly useful in cases where FSM application might be slow due to queries (which is something we need to optimize for better performance).
The new feature depends on hashicorp/raft#640. The current PR version relies on a fork, but I'm happy to move it to Grafana if the PR takes longer to merge.