fix: rideshare tweaks #4075
Open
fix: rideshare tweaks #4075
+55
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
requested changes
Apr 4, 2025
examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile.load-generator
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,6 @@ | |||
| services: | |||
| us-east: | |||
| container_name: us-east | |||
There was a problem hiding this comment.
I'd say this isn't needed 🤔
There was a problem hiding this comment.
its needed so i can add them in the prometheus.yml file without having to use the funky autogenerated name docker gives when not adding it
examples/language-sdk-instrumentation/golang-push/rideshare/rideshare/rideshare.go
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/docker-compose.yml
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/rideshare/rideshare.go
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/loadgen.go
Outdated
Show resolved
Hide resolved
shelldandy
commented
Apr 5, 2025
Comment on lines
+24
to
+26
| - job_name: 'rideshare' | ||
| static_configs: | ||
| - targets: ['us-east:5000', 'eu-north:5000', 'ap-south:5000'] |
There was a problem hiding this comment.
@marcsanmi this is why i need the container names , without this scrape i don't see the metrics i added show up in the explorer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues from: #4011
Needed to add the utf8 metrics to our prometheus config so they're properly scrapped