Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar #413

Merged
merged 4 commits into from
Sep 22, 2021
Merged

Fix search bar #413

merged 4 commits into from
Sep 22, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 22, 2021

Fixes #409

Ended up adding a debounce to the search to make it faster (otherwise on every keystroke we would rerender the flamegraph)

No tests yet since they require visual testing, @ruslanpascoal2 will look into it later.

I think we should merge this as soon as possible and worry about the tests later.

BTW reset view is also broken, working on it in a different PR.

it seems when we split the flamegraph into multiple components
this got broken
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #413 (34fb15b) into main (9bdabca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   50.66%   50.66%           
=======================================
  Files         125      125           
  Lines        5664     5664           
=======================================
  Hits         2869     2869           
  Misses       2519     2519           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feac8b5...34fb15b. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Sep 22, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 158.92 158.70 -0.22 (-0.14%) 5%
total items processed 129495.00 129270.00 -225.00 (-0.17%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against e2e9104

@eh-am eh-am marked this pull request as draft September 22, 2021 16:39
@eh-am eh-am marked this pull request as ready for review September 22, 2021 17:30
@eh-am eh-am merged commit 0b17e11 into main Sep 22, 2021
@eh-am eh-am deleted the 405-search-bar branch September 22, 2021 19:05
@Rperry2174
Copy link
Contributor

@eh-am did this fix it for you? It still looks like its not working for mine. Am I missing something?
image

korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar is not working
3 participants