frontend: apply prettier to cypress/webapp #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eh-am
force-pushed
the
add-prettier
branch
2 times, most recently
from
489890d to
44ac4a7
Compare
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 50.85% 50.85%
=======================================
Files 125 125
Lines 5710 5710
=======================================
Hits 2903 2903
Misses 2528 2528
Partials 279 279 Continue to review full report at Codecov.
|
ParametersDetails
Result
Details
ScreenshotsThroughput
Disk Usage
Memory
Upload Errors (Total)
Successful Uploads (Total)
CPU Utilization
|
idea here is to run eslint + prettier against staged files so that nothing broken is pushed frontend: add cypress eslint plugin frontend: reformat more files
Rperry2174
reviewed
Sep 23, 2021
| @@ -1,13 +1,13 @@ | |||
| import { BAR_HEIGHT } from '../../webapp/javascript/components/FlameGraph/FlameGraphComponent/index.jsx' | |||
| import { BAR_HEIGHT } from '../../webapp/javascript/components/FlameGraph/FlameGraphComponent'; | |||
There was a problem hiding this comment.
Does this cause a problem or is the /index.jsx not needed?
There was a problem hiding this comment.
That's an eslint error
Unexpected use of file extension "jsx" for "../../webapp/javascript/components/FlameGraph/FlameGraphComponent/index.jsx" import/extensions
We weren't catching it before because our lint rule was only applied to js/jsx files (this one is a ts file).
But overall it's not needed, AFAIK all tools follow the convention that foo/index.{js,jsx,ts,tsx} equals to /foo
|
retest this please |
petethepig
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
eslintandprettieragainst ALL files. That is so that everything is consistent (from js files to yamls)This ends up breaking
git blame(since I modified all files).To solve that added a
postinstallscript that runsgit config blame.ignoreRevsFile .git-blame-ignore-revs, which makesgit blameignore commits from the.git-blame-ignore-revsfile.Therefore, we require existing code to run
yarnagain.Plus added
huskyandlint-stagedintegration. Which makes us runeslintandprettierto staged files when committing. That will guarantee all new modifications are formatted.Also added a ci check to validate files have been formatted (let's say the husky hook didn't work for some reason).