Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhoc comparison diff support #652

Merged
merged 12 commits into from
Jan 9, 2022
Merged

Adhoc comparison diff support #652

merged 12 commits into from
Jan 9, 2022

Conversation

abeaumont
Copy link
Contributor

@abeaumont abeaumont commented Dec 23, 2021

Support for adhoc comparison diff view:

  • It works with profiles already saved in the pyroscope data directory, drag & drop isn't supported yet.
  • It supports importing from supported formats (collapsed and pprof, currently).

This is how it looks like:

adhoc-diff-view

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 254.95 KB (+0.14% 🔺) 5.1 s (+0.14% 🔺) 226 ms (+41.03% 🔺) 5.4 s

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #652 (0914e59) into main (b887fd6) will decrease coverage by 0.61%.
The diff coverage is 35.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   75.45%   74.85%   -0.60%     
==========================================
  Files          47       47              
  Lines        1617     1638      +21     
  Branches      295      297       +2     
==========================================
+ Hits         1220     1226       +6     
- Misses        368      381      +13     
- Partials       29       31       +2     
Impacted Files Coverage Δ
webapp/javascript/components/Sidebar.tsx 84.91% <ø> (ø)
webapp/javascript/redux/actions.js 20.91% <28.00%> (-0.33%) ⬇️
webapp/javascript/redux/actionTypes.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b887fd6...0914e59. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 147.02 146.68 -0.34 (-0.23%) 5%
total items processed 121714.00 121590.00 -124.00 (-0.10%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 1b94bbb

@abeaumont abeaumont marked this pull request as ready for review January 4, 2022 11:38
@petethepig petethepig merged commit db79932 into main Jan 9, 2022
@petethepig petethepig deleted the feat/adhoc-comparison-diff branch January 9, 2022 22:11
petethepig pushed a commit that referenced this pull request Jan 9, 2022
petethepig pushed a commit that referenced this pull request Jan 9, 2022
juliosaraiva pushed a commit to juliosaraiva/pyroscope that referenced this pull request Jan 16, 2022
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
…652)

* Update all metrics to be prefixed with pyroscope rather than phlare

* Update dashboards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants