Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timerange bug with Event Stats query #279

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

alyssabull
Copy link
Contributor

@alyssabull alyssabull commented Jun 27, 2024

There was a bug that was not setting the timezone and causing data to:

  • Not accurately reflect a chosen timezone (i.e. displaying UTC time instead of local time)
  • Not accurately display a given time range (i.e. when last 24 hours is chosen, there would be missing data)

Screenshot 2024-06-27 at 4 52 06 PM

The timezone is now added to the params so the data will properly display.

@alyssabull alyssabull requested a review from a team as a code owner June 27, 2024 22:46
@alyssabull alyssabull requested review from asimpson, bossinc, aangelisc and adamyeats and removed request for a team June 27, 2024 22:46
@alyssabull alyssabull changed the title Add timezone to params Fix timerange bug with Event Stats query Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:029b871c92a5cfc988630c23628f3ef37d6dd818pre

pkg/sentry/events_stats.go Outdated Show resolved Hide resolved
@alyssabull alyssabull merged commit 5d3180b into main Jun 27, 2024
8 checks passed
@alyssabull alyssabull deleted the alyssa/events-stats-time-range branch June 27, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants