fix(renovate): fix dry-run mode for manual trigger #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
force-pushed
the
iainlane/renovate-fix-dry-run
branch
from
55bd76f
to
7d85345
Compare
Even though we have `type: boolean` on the input, in [run logs], we can see that we get a string when using it: ``` ....Evaluating String: ....=> 'inputs' ..=> Object ..Evaluating String: ..=> 'dry-run' => 'false' ``` So we'll need to compare with `'true`` as a string. Sad face. [run logs]: https://github.com/grafana/shared-workflows/actions/runs/10940222859/job/30372257412
iainlane
changed the title
iainlane
force-pushed
the
iainlane/renovate-fix-dry-run
branch
from
7d85345
to
f904ad0
Compare
dsotirakis
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we have
type: booleanon the input, in run logs, we can see that we get a string when using it:This means the expression doesn't work. So we'll need to compare with `'true`` as a string. Sad face.