Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print workflow uri immediately even when using --wait flag #663

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

dblinkhorn
Copy link
Contributor

No description provided.

@dblinkhorn dblinkhorn requested a review from a team as a code owner December 20, 2024 22:15
@dblinkhorn dblinkhorn changed the title print workflow uri immediately even when using --wait flag feat: print workflow uri immediately even when using --wait flag Dec 20, 2024
Copy link
Contributor

@zerok zerok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂 Just some minor requests.

@dblinkhorn dblinkhorn added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 32bb517 Jan 7, 2025
9 checks passed
@dblinkhorn dblinkhorn deleted the return-uri-before-completion branch January 7, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger-argo-workflow does not print the workflow url until the workflow completion when --wait flag is used
2 participants