adjusted handling of zero-rows results #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlepp
reviewed
May 22, 2024
|
|
||
| frame.Meta.ExecutedQueryString = query.RawSQL | ||
| frame.Meta.PreferredVisualization = data.VisTypeGraph | ||
|
|
||
| switch query.Format { | ||
| case FormatOptionMulti: | ||
| if zeroRows { | ||
| return nil, ErrorNoResults |
There was a problem hiding this comment.
do we have to return an error? or should we just return an empty frame with a warning?
There was a problem hiding this comment.
this does not cause an error "in the browser". this is only used in the go-code, and eventually it reaches here:
Lines 249 to 251 in 6631da7
so no error is returned. (the dataframe at that point is a more&less empty one, containing the executed-query-string).
personally i'd love to adjust the code to not have this "marker" error, but not sure what others think. also wanted to minimize the size of the diff.
WDYT?
scottlepp
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( fixes #118 )
when the
multiformat was added, we unintentionally changed how we handle zero-rows sql-responses.. previously, for all-formats-except-timeseries, we returned the real dataframe-fields (the fields had zero items in them).this PR adjusts the behavior to be the same as it was before. (i literally took the
dataframe_test.gofile, and ran it on a git-checkout of the old-version, and wrote down the results there).NOTE: there was no format=multi in the "before" situation, so for that case, i kept the current behavior (no dataframe-fields when zero-rows).