pre and post health check methods #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1
This PR updates the return values for the
CheckHealthmethod.When the
CheckHealthfailed, it returns*backend.CheckHealthResult, error. In the above scenario, the error is redundant and causing confusion with the error status in theCheckHealthResult. Due to this incorrect usage of error, drivers like big query shows always connection successful.So removing the return
DownstreamError(err)tonilfrom theHealthChecker.Checkmethod.Change 2
This PR adds support for custom health checks ( pre and post connect checks ). This pre and post checks are optional and will be ignored if not configured.
Note: This is required for drivers such as big query where the
Connectmethod is not sufficient for health check.