fix: return error if not nil when connecting #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
requested review from
a team,
idastambuk and
njvrzm
and removed request for
a team
|
@grafana/enterprise-datasources could you give this PR an approval? It's currently blocked even though it's been approved by our team which is also listed as a code owner. Not sure why that approval isn't being picked up as a code owner review 🤷♂️ |
njvrzm
requested changes
Jan 10, 2025
sasklacz
approved these changes
Jan 14, 2025
ktw4071
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing PDC for the Aurora data source, the healthcheck was always returning a success response even if the PDC agent was not running. This PR returns the error in
connectWithRetriesif one is present and the connection should not be retried.