Bug fixes / context refactor #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Aug 20, 2021
| defer cancel() | ||
|
|
||
| ctx = tctx | ||
| } |
There was a problem hiding this comment.
it' a bit artificial but can we move lines 93:116 to a prepareQuery method? That way we can easily add tests for new/existing code without having to mock the query execution.
Comment on lines
+165
to
+173
| count, err := frame.RowLen() | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if count == 0 { | ||
| return nil, ErrorNoResults | ||
| } |
There was a problem hiding this comment.
it'd be also great to have some test for this, since this is the fix of #16
yesoreyeram
reviewed
Aug 20, 2021
andresmgot
approved these changes
Aug 23, 2021
I'm with you but I think I want to do some refactoring to make this more testable first 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Before:
After:
Also includes fixes:
github.com/pkg/errors, instead we just use the standard libraryerrorspackage withfmt.Errorf.github.com/pkg/errorsin favor oferrors#31This does include a breaking change because of the new function on the interface.