chore: fix test noise #1057
Merged
chore: fix test noise #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've let some test noise creep into our tests which over time has built up to become pretty noisy and frustrating to scroll through when seeing why tests might be failing -- especially in CI/CD.
Solution
I've gone through and fixed the problems at the root level where possible in our codebase, otherwise I've added them to the
silenceErrors.tsfile we have so they are muted. We should periodically review them and see if we can remove them, with the aim of being able to delete this file in the near future.I've also added a little bit of documentation which we can build upon moving forwards.