Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website nav menu borked on mobile #732

Closed
leetrout opened this issue Jul 16, 2022 · 3 comments · Fixed by #876
Closed

Website nav menu borked on mobile #732

leetrout opened this issue Jul 16, 2022 · 3 comments · Fixed by #876

Comments

@leetrout
Copy link

The hamburger menu is not working on mobile. I am on an iphone se.

E7AEB5A4-FFF5-4079-BF2C-2ACB0723BC75

IMG_6027.MOV
@godwhoa
Copy link
Contributor

godwhoa commented Jul 27, 2022

I'm guessing it's an issue with the outdated docz library. I gave upgrading it a try but went down the rabbithole of upgrading gastby and all other dependencies. 😬 Gave up in the end.

julienduchesne added a commit that referenced this issue Aug 1, 2022
@julienduchesne
Upgrade docs versions
a276a08 
An effort at fixing #732
Trying to see if docz 2.4.0 fixes mobile
@julienduchesne julienduchesne mentioned this issue Aug 1, 2022
Merged
julienduchesne added a commit that referenced this issue Aug 1, 2022
@julienduchesne
Upgrade docs versions (#738)
f844ee8 
An effort at fixing #732
Trying to see if docz 2.4.0 fixes mobile
@julienduchesne
Copy link
Member

Upgrading docz did not fix it unfortunately. I don't know much about this Gatsby stuff 😕

@leetrout
Copy link
Author

leetrout commented Aug 2, 2022

Thanks for looking.

I tried it on my desktop and I can recreate the same behavior so that is good since it will be easier to test.

When I move the window very slowly from wide to narrow I can see the sidebar animate away and I see translateX(-100%) in the CSS. I will take a look when I have a free moment if no one else gets here first. Hopefully just a simple state bug where a class is missing or something since the menu click is making the shaded overlay pop.

julienduchesne added a commit that referenced this issue Jun 6, 2023
@julienduchesne
Fix issues with docs website
9dc94fe 
Closes #732
Closes #797

These issues come from the fact that we have custom code for the sidebar
This custom code adds a logo (I moved that to the header) + algolia search (not very useful IMO, just search the github repo)
@julienduchesne julienduchesne mentioned this issue Jun 6, 2023
Merged
julienduchesne added a commit that referenced this issue Jun 7, 2023
@julienduchesne
Fix issues with docs website (#876)
a474f0f 
* Fix issues with docs website
Closes #732
Closes #797

These issues come from the fact that we have custom code for the sidebar
This custom code adds a logo (I moved that to the header) + algolia search (not very useful IMO, just search the github repo)

* Hide helper .mdx files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with docs website grafana/tanka
3 participants
@leetrout @godwhoa @julienduchesne