Add tk lint command
#592
Merged
Add tk lint command
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
commented
Aug 6, 2021
| ) | ||
|
|
||
| // FindFiles takes a file / directory and finds all Jsonnet files | ||
| func FindFiles(target string, excludes []glob.Glob) ([]string, error) { |
There was a problem hiding this comment.
Completely unchanged from where I took it in the format.go file
|
There is still an issue with panics in go-jsonnet: google/go-jsonnet#544 but this is ready to review as far as the tanka side goes. When it doesn't encounter the panic (in specific cases), it works well |
|
It's nice to see Regarding the panic, it's close to the top of my list now. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Marked as keepalive and draft while we wait for go-jsonnet's next release |
julienduchesne
force-pushed
the
julienduchesne/tk-lint
branch
from
40ca520
to
7b3e521
Compare
julienduchesne
force-pushed
the
julienduchesne/tk-lint
branch
from
7b3e521
to
f5ef4e5
Compare
Like `fmt`, this takes a list of dirs/files as argument and evaluates them with the go-jsonnet lint utility The linting results are directly printed out to stderr If there are any linting errors, the command exit with status code 1 #342
The VM creation is duplicated but the impact seems pretty minimal With 4 workers, it's still roughly twice as previously on my very unpowered machine
…nking works better
julienduchesne
force-pushed
the
julienduchesne/tk-lint
branch
from
f5ef4e5
to
ea0f2d3
Compare
|
Bump here :) This would be pretty amazing! |
Duologic
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
fmt, this takes a list of dirs/files as argument and evaluates them with the go-jsonnet lint utilityThe linting results are directly printed out to stderr
If there are any linting errors, the command exit with status code 1
Closes #342