feat(cli): Completions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
added
kind/feature
gouthamve
approved these changes
Aug 6, 2019
Adds a custom bash completion script that kicks in if the subcommand is accepting an environment. It will dynamically look for environments in the child folders and suggest them.
Did only complete baseDirs when in rootDir so far. Now completes whenever we are inside a tanka context
Uses https://github.com/posener/complete instead of the builtin generator of cobra. This has the advantage that we do not rely on scripts anymore but handle our completion ourselves. This furthermore allows us to use native go functions to return predictions. Works now on bash, zsh and fish!
Adds more descriptive error messages, that explain why a certain action was required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does initial work on completing environments when using the commands
eval,apply, etc.Due to limitations in theChanged in 99f72e1spf13/cobralibrary, onlybashis supported at the moment.Closes #5