-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tempo's open-telemetry/collector dependency #1102
Comments
We should probably also look into updating our opentelemetry-proto submodule: Lines 1 to 3 in c5d007d
I don't expect any changes in the traces format, but it's good to stay fairly up-to-date. |
I take it that upgrading the collector dependency will also allow enabling TLS on the otlp receiver? |
The collector was updated in the following PRs
Should we rename this issue (to only update the proto) and move it into the next milestone? |
I'm not sure if we want to bother updating the proto. OTLP traces is declared stable so not much has changed. Maybe we can look into this when we work on new backend formats? |
Is your feature request related to a problem? Please describe.
Tempo depends on go.opentelemetry.io/collector for its receivers. We are currently still using v0.21 while the latest version is already v0.38...
tempo/go.mod
Line 57 in c5d007d
The receivers are used by the distributor: https://github.com/grafana/tempo/search?q=go.opentelemetry.io%2Fcollector
Describe the solution you'd like
Update the dependency.
Update the documentation if this changes any defaults (I'm thinking about #637).
Describe alternatives you've considered
If we don't update we are going to miss out on security and performance improvements.
Additional context
N/A
The text was updated successfully, but these errors were encountered: