Update opentelemetry collector to v0.40.0 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tete17
requested review from
annanay25,
dgzlopes,
joe-elliott,
yvrhdn,
mapno and
mdisibio
as code owners
|
|
|
Relates to #1102 |
mapno
reviewed
Nov 29, 2021
Merged
10 tasks
tete17
force-pushed
the
Update-opentelemetry-collector-dependency
branch
from
88cd773 to
7f6e9f7
Compare
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
tete17
force-pushed
the
Update-opentelemetry-collector-dependency
branch
from
7f6e9f7 to
a748f53
Compare
mapno
approved these changes
Dec 3, 2021
|
Hey @tete17, it seems that the CI failed at two checks
Thanks again! |
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
|
Hey @mapno sorry for the silly mistakes the vendor issue must have slipped me with the rebase and the deprecated function I saw in the first ci run and did nothing my bad. Should be fixed now 😄 |
|
I tried running the e2e tests locally and found no error. Are they run against what would be the result of the merge or the branch of the MR? Could it be just a fluke? can we run them again? |
joe-elliott
approved these changes
Dec 6, 2021
3 tasks
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR updates the opentelemetry-collector dependency to 0.40.0
We can consider it a sibling of this PR grafana/helm-charts#855. The reason is the old version still had the wrong default port number for otel http endpoint. By upgrading the dependency we make sure to always use the port 4318 and avoid future confusion.
The changes are fairly minor, most of my work was going through the changelog and see the renaming of symbols they did. The biggest hurdles were the change they did in config parsing and the fact that the metrics for collectors are now hidden due under an internal package, see open-telemetry/opentelemetry-collector#3253.
Both changes are mostly reflected in the file
modules/distributor/receiver/shim.go. That can be a good point of focus for anyone willing to review this change. Ignoring the vendor folder it shouldn't be that big.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]