-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to Add Configuration Verification Option #2131
Comments
This is a great idea. I will point out that we have a "CheckConfig" method that will provide warnings on configs that parse correctly but have potentially bad combinations of settings: https://github.com/grafana/tempo/blob/main/cmd/tempo/app/config.go#L128 I think verify config should parse the config, run it through this method and print out any warnings/errors. |
Thank you for pointing out the "CheckConfig" method as a potential solution. I appreciate your input and will look into implementing this flag in Tempo. Once I have made the necessary changes, I will create a pull request for review. |
Hi @joe-elliott, |
* Add configuration verification flag to CLI Co-authored-by: Robert Scherbarth <r.scherbarth@icloud.com> * centralize config verify call to load config Co-authored-by: Dennis Brigadenko <dennis.brigadenko@paymenttools.com> --------- Co-authored-by: Robert Scherbarth <r.scherbarth@icloud.com>
Hi, |
Issue Report: Adding a Config Verification Option to Tempo
Problem:
I am trying to validate the Tempo configuration file before deploying it. However, I have noticed that there is currently no option available to verify the configuration file.
Proposed Solution:
I would like to request the addition of a configuration verification option in Tempo, similar to the "verify-config" option available in Loki, which allows for the validation of configuration syntax before applying the configuration. This option would be very useful to have when deploying and managing Tempo, as it would ensure that the configuration file is valid and reduce the risk of errors during deployment.
Additional Context:
Currently, there is no option available to check the syntax of the configuration file in Tempo, which is available in other related tools such as Loki and Mimir. I believe that adding this option to Tempo would make the tool more versatile and user-friendly.
The text was updated successfully, but these errors were encountered: