Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo mixin: alert and recording rules make range interval configurable #3815

Closed
jmichalek132 opened this issue Jun 27, 2024 · 1 comment · Fixed by #3851
Closed

Tempo mixin: alert and recording rules make range interval configurable #3815

jmichalek132 opened this issue Jun 27, 2024 · 1 comment · Fixed by #3851

Comments

@jmichalek132
Copy link
Contributor

jmichalek132 commented Jun 27, 2024

Is your feature request related to a problem? Please describe.

In our case we have scrape interval of 1m, however one alert and recording rules in the mixin seem to have hardcoded range interval, examples:

https://github.com/grafana/tempo/blob/main/operations/tempo-mixin/alerts.libsonnet#L202
https://github.com/grafana/tempo/blob/main/operations/tempo-mixin-compiled/rules.yaml#L4

Describe the solution you'd like

Have a config option for the range interval window in alerts, similar to what is already present for recording rules in mimir mixin. https://github.com/grafana/mimir/blob/main/operations/mimir-mixin/config.libsonnet#L666.

Describe alternatives you've considered

Manually editing the alerts after they are rendered, which kind of defeats the point of mixins imho.

Additional context

https://www.robustperception.io/what-range-should-i-use-with-rate/
I can raise a PR for the changes.

@joe-elliott
Copy link
Member

Yup, I think this is a solid improvement and would love to see a PR. Thanks for raising an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants