-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update mixin deps and add recording_rules_range_interval #3851
Merged
mapno
merged 4 commits into
grafana:main
from
jmichalek132:jm-chore-mixin-make-range-interval-configurable
Jul 11, 2024
Merged
chore: update mixin deps and add recording_rules_range_interval #3851
mapno
merged 4 commits into
grafana:main
from
jmichalek132:jm-chore-mixin-make-range-interval-configurable
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichalek132
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
July 9, 2024 13:10
jmichalek132
commented
Jul 9, 2024
mapno
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add a changelog entry?
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
July 10, 2024 13:21
57cf4f1
to
d607c5b
Compare
mapno
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks Juraj :)
auto-merge was automatically disabled
July 11, 2024 09:48
Head branch was pushed to by a user without write access
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
July 11, 2024 09:48
d607c5b
to
45c3a84
Compare
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
July 11, 2024 09:51
45c3a84
to
a3f7452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
histogramRules
which allows specifying range_interval)recording_rules_range_interval
to allow overriding the range_interval in recording rules.Which issue(s) this PR fixes:
Fixes #3815
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]