Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mixin deps and add recording_rules_range_interval #3851

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented Jul 9, 2024

What this PR does:

  • Updating the mixin deps (needed to have newer version of histogramRules which allows specifying range_interval)
  • Adding a mixin config option recording_rules_range_interval to allow overriding the range_interval in recording rules.

Which issue(s) this PR fixes:
Fixes #3815

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a changelog entry?

operations/tempo-mixin/alerts.libsonnet Show resolved Hide resolved
@jmichalek132 jmichalek132 force-pushed the jm-chore-mixin-make-range-interval-configurable branch from 57cf4f1 to d607c5b Compare July 10, 2024 13:21
@jmichalek132 jmichalek132 requested a review from mapno July 10, 2024 14:36
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Juraj :)

@mapno mapno enabled auto-merge (squash) July 11, 2024 06:41
auto-merge was automatically disabled July 11, 2024 09:48

Head branch was pushed to by a user without write access

@jmichalek132 jmichalek132 force-pushed the jm-chore-mixin-make-range-interval-configurable branch from d607c5b to 45c3a84 Compare July 11, 2024 09:48
@jmichalek132 jmichalek132 force-pushed the jm-chore-mixin-make-range-interval-configurable branch from 45c3a84 to a3f7452 Compare July 11, 2024 09:51
@mapno mapno merged commit 4655d25 into grafana:main Jul 11, 2024
14 checks passed
@jmichalek132 jmichalek132 deleted the jm-chore-mixin-make-range-interval-configurable branch July 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempo mixin: alert and recording rules make range interval configurable
3 participants