Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export trace id constant in api package #1176

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

wperron
Copy link
Contributor

@wperron wperron commented Dec 13, 2021

What this PR does:

Export the URLParamTraceID constant in the api package as this constant was already exported in the util package prior to version 1.2.

Checklist

  • [ ] Tests updated
  • [ ] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2021

CLA assistant check
All committers have signed the CLA.

@joe-elliott
Copy link
Member

I'm good on this. You just need to sign the CLA and we'll merge.

@wperron
Copy link
Contributor Author

wperron commented Dec 13, 2021

I'm good on this. You just need to sign the CLA and we'll merge.

Yup, just waiting on internal approval on that front, should be done later this week 👍

@wperron wperron force-pushed the fix/api-export-const branch from 4d49452 to 43cc39e Compare December 16, 2021 21:58
@yvrhdn yvrhdn merged commit 161073a into grafana:main Dec 17, 2021
@wperron wperron deleted the fix/api-export-const branch December 17, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants