-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config options to manage variables expansion #1212
Conversation
Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: irizzant <i.rizzante@gmail.com> # Conflicts: # example/tk/jsonnetfile.lock.json
Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: irizzant <i.rizzante@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition. just asking for some minor cleanup to the changelog.
@irizzant CI was broken in main. If you could rebase/merge main CI should pass and we can get this merged. |
@joe-elliott that makes sense...I updated the branch as you suggested it should be ok then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for the contribution!
What this PR does:
This PR adds support for specifying config options to manage variables expansion in a single point.
For example, to enable S3 storage backend simply add the following to the
_config
object:where
S3_ACCESS_KEY
andS3_SECRET_KEY
are taken for a secret namedminio-secret
.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]