Add a startTime and endTime parameter to the trace by id query API to improve query performance

[sagarwala]

What this PR does:
This PR adds a startTime and endTime parameter to the Trace By ID API call, to restrict the number of blocks parsed while querying based on the time of the block. Default behaviour remains same if the time window is not specified.
The API spec would now be /api/traces/{traceID}?timeEnd={end}&timeStart={start}

Which issue(s) this PR fixes:
Fixes #1373

cc : @bikashmishra100 @ashwinidulams

Checklist

• Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[CLAassistant]

All committers have signed the CLA.

[joe-elliott]

Overall this is pretty close. I appreciate the work that's done here. We are close to cutting 1.4 and if we hustle we can get this feature in that release (which I would like).

In addition to the requested changes we also need to add these new params to our docs:

https://github.com/grafana/tempo/blob/main/docs/tempo/website/api_docs/_index.md?plain=1#L100

It's also very important that while we describe these new fields carefully in the docs. If the start/end parameters are provided it's quite possible that the trace will not be found or returned partially.

We should also mention the interaction between these new params and this config option:

https://github.com/grafana/tempo/blob/main/docs/tempo/website/configuration/_index.md?plain=1#L776

If a span is received that is outside that slack configuration value then the block start/end times are not updated. This currently has no impact on trace by id search b/c it searches everywhere.

However, after this change, if you push a trace with dates from last week and then search for that trace using /api/traces/<id>?start=<val>&end=<val> then it will not be returned even if start/end correctly overlap with the trace.

Thanks for this feature addition. Let's clean this up some and try to get it merged for 1.4!

[sagarwala]

Thank you for the review comments @joe-elliott.

I have updated the documentation to include start/end parameters and added details on ingestion_time_range_slack configuration. The ValidateAndSanitizeRequest method is now added to package/api and I am using the same for frontend as well as querier request validation. The test cases are also updated to include the start and end parameters.

[joe-elliott]

a few more nits and we'll be good to merge. thanks!

[sagarwala]

Updated the documentation and tests as per PR comments. Thanks much @joe-elliott for your time and review.

[joe-elliott]

Two small changes and we'll merge!

• Move the warning in the docs. (I added a note on the exact line I'm concerned about).
• Add a change log entry

[sagarwala]

Done! Thank you!

[joe-elliott]

Really cool enhancement. Great addition @sagarwala!