Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configuration option for the querier to only hit the ingesters based on the trace id hashes instead of all healthy ingesters #1484

Merged
merged 10 commits into from
Jun 13, 2022

Conversation

sagarwala
Copy link
Contributor

What this PR does:
Implement configuration option for the querier to only hit the ingesters based on the trace id hashes instead of all healthy ingesters

Which issue(s) this PR fixes:
Fixes #1477

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Koenraad Verheyden and others added 6 commits May 5, 2022 18:50
…t setups (grafana#1417)

* metrics-generator: don't inject X-Scope-OrgID header for single-tenant setups

* Update CHANGELOG.md
…t honoring max_bytes_per_trace (grafana#1420)

* Fix compactor to record compaction_objects_combined_total and honor max_bytes_per_trace again

* changelog
…grafana#1422)

* distributor: prevent panics when concurrently calling  to forwarder's queueManager

* Update PR number

* Pin k6 version to v0.37.0
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Had a few comments and suggestions.

modules/querier/querier.go Outdated Show resolved Hide resolved
modules/querier/config.go Outdated Show resolved Hide resolved
docs/tempo/website/configuration/_index.md Outdated Show resolved Hide resolved
docs/tempo/website/configuration/_index.md Outdated Show resolved Hide resolved
@sagarwala
Copy link
Contributor Author

Thank you @joe-elliott . I have updated the PR as per the comments. I am using query_relevant_ingesters for the config name :)

Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Thanks!

@joe-elliott joe-elliott enabled auto-merge (squash) June 13, 2022 18:45
@joe-elliott joe-elliott merged commit cd21a9a into grafana:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants