Bug fix relating to Cluster Seed File #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
reviewed
Aug 8, 2022
ie-pham
requested review from
joe-elliott,
annanay25,
mapno,
yvrhdn and
zalegrala
as code owners
mdisibio
approved these changes
Aug 8, 2022
zalegrala
approved these changes
Aug 8, 2022
joe-elliott
reviewed
Aug 8, 2022
| list, err := r.r.List(ctx, nil) | ||
|
|
||
| // this filter is added to fix a GCS usage stats issue that would result in "" | ||
| var filteredList []string |
There was a problem hiding this comment.
minor but we should have preallocated this slice to match the tenants length.
a test on this behavior also would have been nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR fixes an issue for GCS when anonymous usage stats is enabled. Due to the cluster seed file being in the same folder, an incorrect tenant id of an empty string gets returned in the List() call.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]