Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for time range queries on jaeger plugin #1631

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented Aug 11, 2022

Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com

What this PR does:

Which issue(s) this PR fixes:
Fixes #1619

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2022

CLA assistant check
All committers have signed the CLA.

@joe-elliott
Copy link
Member

Nice! We've kind of let jaeger-query fall by the wayside. It's original purpose was simply to allow Grafana to query Tempo. Since Grafana has supported Tempo directly we've kind of forgotten about this piece.

Can you add a changelog entry please?

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510
Copy link
Contributor Author

Nice! We've kind of let jaeger-query fall by the wayside. It's original purpose was simply to allow Grafana to query Tempo. Since Grafana has supported Tempo directly we've kind of forgotten about this piece.

Can you add a changelog entry please?

Thanks for the review!, changelog entry added

@joe-elliott
Copy link
Member

So obviously we no longer use this feature and there are no tests. If you are able after this is merged to test the new image, it would be appreciated.

Thanks for the contribution!

@joe-elliott joe-elliott merged commit 8cb46b4 into grafana:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for time picker in tempo-query
3 participants