Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span size as a new metrics to metrics generator #1662

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Add span size as a new metrics to metrics generator #1662

merged 2 commits into from
Aug 19, 2022

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Aug 18, 2022

What this PR does: This PR adds span size as a new metrics to metrics generator.

Which issue(s) this PR fixes:
Fixes #1615

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ie-pham ie-pham changed the title add span size metrics to spanmetrics in metrics generator Add span size metrics to spanmetrics in metrics generator Aug 19, 2022
@ie-pham ie-pham marked this pull request as ready for review August 19, 2022 01:56
@ie-pham ie-pham changed the title Add span size metrics to spanmetrics in metrics generator Add span size as a new metrics to metrics generator. Aug 19, 2022
@ie-pham ie-pham changed the title Add span size as a new metrics to metrics generator. Add span size as a new metrics to metrics generator Aug 19, 2022
Copy link
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks good to me. Re running the failing test.

@ie-pham ie-pham requested a review from zalegrala August 19, 2022 14:08
@zalegrala zalegrala merged commit 08aef83 into grafana:main Aug 19, 2022
@ie-pham ie-pham deleted the jennie/1615 branch March 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include size of the spans in span metrics
2 participants