Add hedged request to trace by ID #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
force-pushed
the
frontend-hedging
branch
from
b5da317 to
053fea3
Compare
mapno
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
yvrhdn and
zalegrala
as code owners
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
knylander-grafana
approved these changes
Sep 13, 2022
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
joe-elliott
reviewed
Sep 13, 2022
| @@ -16,7 +16,7 @@ go run ./cmd/tempo --storage.trace.backend=local --storage.trace.local.path=/tmp | |||
|
|
|||
| ## Complete configuration | |||
|
|
|||
| > **Note**: This manifest was generated on 2022-03-29. | |||
| > **Note**: This manifest was generated on 2022-09-13. | |||
There was a problem hiding this comment.
thank you for regenerating this :)
joe-elliott
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds hedging to trace by ID lookups in the
query-frontend.Also, deprecates
query-frontend.query_shardsin favor ofquery_frontend.trace_by_id.query_shardsChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]