Avoid running pool jobs with a cancelled context #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, jobs will continue to get scheduled, even if the context has been cancelled. Here we include a check and avoid doing work if we have been asked to stop. Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
zalegrala
force-pushed
the
tempodbCancel
branch
from
3f647dd to
0e47d73
Compare
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno and
yvrhdn
as code owners
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, jobs will continue to get scheduled, even if the context has been cancelled. Here we include a check and avoid doing work if we have been asked to stop.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]