Use xk6-client-tracing in examples to generate traces #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the synthetic-load-generator with xk6-client-tracing in docker-compose examples The grafana7.4 example still uses the load generator because it requires the generated trace IDs to be logged for querying
The file is no longer used by multiple examples
stoewer
force-pushed
the
examples-replace-load-generator
branch
from
08eb4f2 to
8428d88
Compare
stoewer
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Dec 1, 2022
|
Nice! Now I can get a macbook pro ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Replace the synthetic-load-generator with xk6-client-tracing in docker-compose examples.
The grafana7.4 example still uses the load generator because it requires the generated trace IDs to be logged for querying.
Upgrade Grafana used in the examples to the latest version.
Which issue(s) this PR fixes:
Service graphs are now working in all docker-compose examples that use xk6-client-tracing.
Fixes #902
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]