Add support for TraceQL in Parquet WAL and Local Blocks #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
mapno
reviewed
Dec 28, 2022
joe-elliott
reviewed
Jan 3, 2023
|
I'm currently in the middle of a config refactor that has the potential to strongly conflict with this PR. Please ignore the review comments about adjusting tests. I will handle it on my side. |
electron0zero
force-pushed
the
wal_traceql
branch
from
be6e515 to
213ba9d
Compare
electron0zero
changed the title
joe-elliott
approved these changes
Jan 6, 2023
joe-elliott
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for TraceQL in Parquet WAL and Local Blocks in ingester. We added Parquet WAL in #1878, but TraceQL Search is not supported in ingester
How?
In ingesters, a trace can be live, in headBlock, in the completing blocks and complete blocks.
we search in this order: HeadBlock, CompletingBlocks, and completeBlocks.
search is done by Iterating over blocks, executing TraceQL, and finally collecting results.
note: searching liveTraces is not supported yet
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]